Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make account number in welcome view copyable #7755

Merged

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Mar 5, 2025

Why this needs to be done

The text says: Here is your account number. Save it!
But it is not possible to select it and there is no copy to clipboard button.

What needs to be done

Add a copy to clipboard button next to the account number.

Acceptance criteria

There is a copy to clipboard button and it copies the account number to the clipboard

Tests
None


This change is Reviewable

Copy link

linear bot commented Mar 5, 2025

@rablador rablador requested review from buggmagnet and mojganii March 5, 2025 09:25
@rablador rablador self-assigned this Mar 5, 2025
@rablador rablador added the iOS Issues related to iOS label Mar 5, 2025
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@rablador rablador force-pushed the make-account-number-in-welcome-view-copyable-ios-1107 branch from 352efd6 to d1a6063 Compare March 6, 2025 09:36
@rablador rablador merged commit 0789286 into main Mar 6, 2025
12 checks passed
@rablador rablador deleted the make-account-number-in-welcome-view-copyable-ios-1107 branch March 6, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants